Skip to content

Commit

Permalink
merge-ort: avoid surprise with new sub_flag variable
Browse files Browse the repository at this point in the history
Commit 4057523 ("submodule merge: update conflict error message",
2022-08-04) added a sub_flag variable that is used to store a value from
enum conflict_and_info_types, but initializes it with a value of -1 that
does not correspond to any of the conflict_and_info_types.  The code may
never set it to a valid value and yet still use it, which can be
surprising when reading over the code at first.  Initialize it instead
to the generic CONFLICT_SUBMODULE_FAILED_TO_MERGE value, which is still
distinct from the two values we need to special case.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
newren authored and gitster committed Aug 18, 2022
1 parent a5834b7 commit 34ce504
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion merge-ort.c
Expand Up @@ -1767,7 +1767,7 @@ static int merge_submodule(struct merge_options *opt,
int i;
int search = !opt->priv->call_depth;
int sub_not_initialized = 1;
int sub_flag = -1;
int sub_flag = CONFLICT_SUBMODULE_FAILED_TO_MERGE;

/* store fallback answer in result in case we fail */
oidcpy(result, opt->priv->call_depth ? o : a);
Expand Down

0 comments on commit 34ce504

Please sign in to comment.