Skip to content

Commit

Permalink
commit: factor status configuration is a helper function
Browse files Browse the repository at this point in the history
cmd_commit and cmd_status use very similar code to initialize the
wt_status structure. Factor this code into a function to ensure future
changes will keep both versions consistent.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
moy authored and gitster committed Sep 12, 2013
1 parent e230c56 commit 5c25dfa
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions builtin/commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,14 @@ static void determine_whence(struct wt_status *s)
s->whence = whence;
}

static void status_init_config(struct wt_status *s, config_fn_t fn)
{
wt_status_prepare(s);
gitmodules_config();
git_config(fn, s);
determine_whence(s);
}

static void rollback_index_files(void)
{
switch (commit_style) {
Expand Down Expand Up @@ -1246,10 +1254,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
if (argc == 2 && !strcmp(argv[1], "-h"))
usage_with_options(builtin_status_usage, builtin_status_options);

wt_status_prepare(&s);
gitmodules_config();
git_config(git_status_config, &s);
determine_whence(&s);
status_init_config(&s, git_status_config);
argc = parse_options(argc, argv, prefix,
builtin_status_options,
builtin_status_usage, 0);
Expand Down Expand Up @@ -1492,11 +1497,8 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
if (argc == 2 && !strcmp(argv[1], "-h"))
usage_with_options(builtin_commit_usage, builtin_commit_options);

wt_status_prepare(&s);
gitmodules_config();
git_config(git_commit_config, &s);
status_init_config(&s, git_commit_config);
status_format = STATUS_FORMAT_NONE; /* Ignore status.short */
determine_whence(&s);
s.colopts = 0;

if (get_sha1("HEAD", sha1))
Expand Down

0 comments on commit 5c25dfa

Please sign in to comment.