Skip to content

Commit

Permalink
Merge branch 'mm/die-with-dashdash-help' into maint-1.7.11
Browse files Browse the repository at this point in the history
When the user gives an argument that can be taken as both a
revision name and a pathname without disambiguating with "--", we
used to give a help message "Use '--' to separate".  The message
has been clarified to show where that '--' goes on the command
line.

* mm/die-with-dashdash-help:
  setup: clarify error messages for file/revisions ambiguity
  • Loading branch information
gitster committed Sep 10, 2012
2 parents 3d4003b + 4d4b573 commit 5f9d8e3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions setup.c
Expand Up @@ -82,7 +82,7 @@ static void NORETURN die_verify_filename(const char *prefix,

if (!diagnose_misspelt_rev)
die("%s: no such path in the working tree.\n"
"Use '-- <path>...' to specify paths that do not exist locally.",
"Use 'git <command> -- <path>...' to specify paths that do not exist locally.",
arg);
/*
* Saying "'(icase)foo' does not exist in the index" when the
Expand All @@ -96,7 +96,8 @@ static void NORETURN die_verify_filename(const char *prefix,

/* ... or fall back the most general message. */
die("ambiguous argument '%s': unknown revision or path not in the working tree.\n"
"Use '--' to separate paths from revisions", arg);
"Use '--' to separate paths from revisions, like this:\n"
"'git <command> [<revision>...] -- [<file>...]'", arg);

}

Expand Down Expand Up @@ -145,7 +146,8 @@ void verify_non_filename(const char *prefix, const char *arg)
if (!check_filename(prefix, arg))
return;
die("ambiguous argument '%s': both revision and filename\n"
"Use '--' to separate filenames from revisions", arg);
"Use '--' to separate paths from revisions, like this:\n"
"'git <command> [<revision>...] -- [<file>...]'", arg);
}

/*
Expand Down

0 comments on commit 5f9d8e3

Please sign in to comment.