Skip to content

Commit

Permalink
Merge branch 'mv/log-since-as-filter'
Browse files Browse the repository at this point in the history
"git log --since=X" will stop traversal upon seeing a commit that
is older than X, but there may be commits behind it that is younger
than X when the commit was created with a faulty clock.  A new
option is added to keep digging without stopping, and instead
filter out commits with timestamp older than X.

* mv/log-since-as-filter:
  log: "--since-as-filter" option is a non-terminating "--since" variant
  • Loading branch information
gitster committed May 20, 2022
2 parents 2e96975 + 9669778 commit 6f24da6
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Documentation/rev-list-options.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ ordering and formatting options, such as `--reverse`.
--after=<date>::
Show commits more recent than a specific date.

--since-as-filter=<date>::
Show all commits more recent than a specific date. This visits
all commits in the range, rather than stopping at the first commit which
is older than a specific date.

--until=<date>::
--before=<date>::
Show commits older than a specific date.
Expand Down
10 changes: 10 additions & 0 deletions revision.c
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,9 @@ static int limit_list(struct rev_info *revs)
if (revs->min_age != -1 && (commit->date > revs->min_age) &&
!revs->line_level_traverse)
continue;
if (revs->max_age_as_filter != -1 &&
(commit->date < revs->max_age_as_filter) && !revs->line_level_traverse)
continue;
date = commit->date;
p = &commit_list_insert(commit, p)->next;

Expand Down Expand Up @@ -1838,6 +1841,7 @@ void repo_init_revisions(struct repository *r,
revs->dense = 1;
revs->prefix = prefix;
revs->max_age = -1;
revs->max_age_as_filter = -1;
revs->min_age = -1;
revs->skip_count = -1;
revs->max_count = -1;
Expand Down Expand Up @@ -2218,6 +2222,9 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
} else if ((argcount = parse_long_opt("since", argv, &optarg))) {
revs->max_age = approxidate(optarg);
return argcount;
} else if ((argcount = parse_long_opt("since-as-filter", argv, &optarg))) {
revs->max_age_as_filter = approxidate(optarg);
return argcount;
} else if ((argcount = parse_long_opt("after", argv, &optarg))) {
revs->max_age = approxidate(optarg);
return argcount;
Expand Down Expand Up @@ -3862,6 +3869,9 @@ enum commit_action get_commit_action(struct rev_info *revs, struct commit *commi
if (revs->min_age != -1 &&
comparison_date(revs, commit) > revs->min_age)
return commit_ignore;
if (revs->max_age_as_filter != -1 &&
comparison_date(revs, commit) < revs->max_age_as_filter)
return commit_ignore;
if (revs->min_parents || (revs->max_parents >= 0)) {
int n = commit_list_count(commit->parents);
if ((n < revs->min_parents) ||
Expand Down
1 change: 1 addition & 0 deletions revision.h
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ struct rev_info {
int skip_count;
int max_count;
timestamp_t max_age;
timestamp_t max_age_as_filter;
timestamp_t min_age;
int min_parents;
int max_parents;
Expand Down
41 changes: 41 additions & 0 deletions t/t4217-log-limit.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/bin/sh

test_description='git log with filter options limiting the output'

. ./test-lib.sh

test_expect_success 'setup test' '
git init &&
echo a >file &&
git add file &&
GIT_COMMITTER_DATE="2021-02-01 00:00" git commit -m init &&
echo a >>file &&
git add file &&
GIT_COMMITTER_DATE="2022-02-01 00:00" git commit -m first &&
echo a >>file &&
git add file &&
GIT_COMMITTER_DATE="2021-03-01 00:00" git commit -m second &&
echo a >>file &&
git add file &&
GIT_COMMITTER_DATE="2022-03-01 00:00" git commit -m third
'

test_expect_success 'git log --since-as-filter=...' '
git log --since-as-filter="2022-01-01" --format=%s >actual &&
cat >expect <<-\EOF &&
third
first
EOF
test_cmp expect actual
'

test_expect_success 'git log --children --since-as-filter=...' '
git log --children --since-as-filter="2022-01-01" --format=%s >actual &&
cat >expect <<-\EOF &&
third
first
EOF
test_cmp expect actual
'

test_done

0 comments on commit 6f24da6

Please sign in to comment.