Skip to content

Commit

Permalink
completion: synchronize zsh wrapper
Browse files Browse the repository at this point in the history
So it's closer to the full zsh wrapper.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Felipe Contreras authored and gitster committed May 8, 2013
1 parent 2bcf694 commit 734b2f0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contrib/completion/git-completion.bash
Expand Up @@ -2663,7 +2663,7 @@ if [[ -n ${ZSH_VERSION-} ]]; then
--*=*|*.) ;;
*) c="$c " ;;
esac
array[$#array+1]="$c"
array+=("$c")

This comment has been minimized.

Copy link
@ymattw

ymattw Jul 18, 2013

Why revert this change? += syntax does not work for bash < 3.1.

This comment has been minimized.

Copy link
@peff

peff Jul 18, 2013

Member

I suspect it is simply the case that nobody noticed, because most people are not running such an old version of bash. However, nobody is likely to notice your comment here; please send a note to git@vger.kernel.org.

This comment has been minimized.

Copy link
@ymattw

ymattw Jul 24, 2013

Thanks for the hint. I've sent them a note.

done
compset -P '*[=:]'
compadd -Q -S '' -p "${2-}" -a -- array && _ret=0
Expand Down Expand Up @@ -2696,7 +2696,7 @@ if [[ -n ${ZSH_VERSION-} ]]; then
prev=${words[CURRENT-1]}
let cword=CURRENT-1
emulate ksh -c __${service}_main
let _ret && _default -S '' && _ret=0
let _ret && _default && _ret=0
return _ret
}

Expand Down

0 comments on commit 734b2f0

Please sign in to comment.