Skip to content

Commit

Permalink
t4068: remove unnecessary >tmp
Browse files Browse the repository at this point in the history
The many `git diff` invocations have a `>tmp` redirection even though
the file is not being used afterwards. Remove these unnecessary
redirections.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Denton-L authored and gitster committed Sep 17, 2020
1 parent 54e85e7 commit 8023a5e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions t/t4068-diff-symmetric.sh
Expand Up @@ -64,27 +64,27 @@ test_expect_success 'diff with two merge bases' '
'

test_expect_success 'diff with no merge bases' '
test_must_fail git diff br2...br3 >tmp 2>err &&
test_must_fail git diff br2...br3 2>err &&
test_i18ngrep "fatal: br2...br3: no merge base" err
'

test_expect_success 'diff with too many symmetric differences' '
test_must_fail git diff br1...master br2...br3 >tmp 2>err &&
test_must_fail git diff br1...master br2...br3 2>err &&
test_i18ngrep "usage" err
'

test_expect_success 'diff with symmetric difference and extraneous arg' '
test_must_fail git diff master br1...master >tmp 2>err &&
test_must_fail git diff master br1...master 2>err &&
test_i18ngrep "usage" err
'

test_expect_success 'diff with two ranges' '
test_must_fail git diff master br1..master br2..br3 >tmp 2>err &&
test_must_fail git diff master br1..master br2..br3 2>err &&
test_i18ngrep "usage" err
'

test_expect_success 'diff with ranges and extra arg' '
test_must_fail git diff master br1..master commit-D >tmp 2>err &&
test_must_fail git diff master br1..master commit-D 2>err &&
test_i18ngrep "usage" err
'

Expand Down

0 comments on commit 8023a5e

Please sign in to comment.