Skip to content

Commit

Permalink
libsecret: retrieve empty password
Browse files Browse the repository at this point in the history
Since 0ce02e2 (credential/libsecret: store new attributes, 2023-06-16)
a test that stores empty username and password fails when
t0303-credential-external.sh is run with
GIT_TEST_CREDENTIAL_HELPER=libsecret.

Retrieve empty password carefully. This fixes test:

    ok 14 - helper (libsecret) can store empty username

Signed-off-by: M Hickford <mirth.hickford@gmail.com>
  • Loading branch information
hickford committed Feb 18, 2024
1 parent 3e0d3cd commit 877bbfb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions contrib/credential/libsecret/git-credential-libsecret.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ static int keyring_get(struct credential *c)
if (g_strv_length(parts) >= 1) {
g_free(c->password);
c->password = g_strdup(parts[0]);
} else {
g_free(c->password);
c->password = strdup("");
}
for (int i = 1; i < g_strv_length(parts); i++) {
if (g_str_has_prefix(parts[i], "password_expiry_utc=")) {
Expand Down

0 comments on commit 877bbfb

Please sign in to comment.