Skip to content

Commit

Permalink
hooks--pre-push.sample: use hash-agnostic zero OID
Browse files Browse the repository at this point in the history
The pre-push sample hook has the zero OID hardcoded as 40 zeros.
However, with the introduction of SHA-256 support, this assumption no
longer holds true. Replace the hardcoded $z40 with a call to

	git hash-object --stdin </dev/null | tr '[0-9a-f]' '0'

so the sample hook becomes hash-agnostic.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Denton-L authored and gitster committed Sep 23, 2020
1 parent 6a117da commit 8c7e505
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions templates/hooks--pre-push.sample
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
remote="$1"
url="$2"

z40=0000000000000000000000000000000000000000
zero=$(git hash-object --stdin </dev/null | tr '[0-9a-f]' '0')

while read local_ref local_oid remote_ref remote_oid
do
if test "$local_oid" = $z40
if test "$local_oid" = "$zero"
then
# Handle delete
:
else
if test "$remote_oid" = $z40
if test "$remote_oid" = "$zero"
then
# New branch, examine all commits
range="$local_oid"
Expand Down

0 comments on commit 8c7e505

Please sign in to comment.