Skip to content

Commit

Permalink
commit-tree: teach -m/-F options to read logs from elsewhere
Browse files Browse the repository at this point in the history
Just like "git commit" does.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
gitster committed Nov 13, 2011
1 parent 79a9312 commit 96b8d93
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 6 deletions.
16 changes: 13 additions & 3 deletions Documentation/git-commit-tree.txt
Expand Up @@ -9,15 +9,17 @@ git-commit-tree - Create a new commit object
SYNOPSIS
--------
[verse]
'git commit-tree' <tree> [(-p <parent commit>)...] < changelog
'git commit-tree' <tree> [(-p <parent>)...] < changelog
'git commit-tree' [(-p <parent>)...] [(-m <message>)...] [(-F <file>)...] <tree>

DESCRIPTION
-----------
This is usually not what an end user wants to run directly. See
linkgit:git-commit[1] instead.

Creates a new commit object based on the provided tree object and
emits the new commit object id on stdout.
emits the new commit object id on stdout. The log message is read
from the standard input, unless `-m` or `-F` options are given.

A commit object may have any number of parents. With exactly one
parent, it is an ordinary commit. Having more than one parent makes
Expand All @@ -39,9 +41,17 @@ OPTIONS
<tree>::
An existing tree object

-p <parent commit>::
-p <parent>::
Each '-p' indicates the id of a parent commit object.

-m <message>::
A paragraph in the commig log message. This can be given more than
once and each <message> becomes its own paragraph.

-F <file>::
Read the commit log message from the given file. Use `-` to read
from the standard input.


Commit Information
------------------
Expand Down
43 changes: 40 additions & 3 deletions builtin/commit-tree.c
Expand Up @@ -9,7 +9,7 @@
#include "builtin.h"
#include "utf8.h"

static const char commit_tree_usage[] = "git commit-tree <sha1> [(-p <sha1>)...] < changelog";
static const char commit_tree_usage[] = "git commit-tree [(-p <sha1>)...] [-m <message>] [-F <file>] <sha1> <changelog";

static void new_parent(struct commit *parent, struct commit_list **parents_p)
{
Expand Down Expand Up @@ -51,15 +51,52 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
continue;
}

if (!strcmp(arg, "-m")) {
if (argc <= ++i)
usage(commit_tree_usage);
if (buffer.len)
strbuf_addch(&buffer, '\n');
strbuf_addstr(&buffer, argv[i]);
strbuf_complete_line(&buffer);
continue;
}

if (!strcmp(arg, "-F")) {
int fd;

if (argc <= ++i)
usage(commit_tree_usage);
if (buffer.len)
strbuf_addch(&buffer, '\n');
if (!strcmp(argv[i], "-"))
fd = 0;
else {
fd = open(argv[i], O_RDONLY);
if (fd < 0)
die_errno("git commit-tree: failed to open '%s'",
argv[i]);
}
if (strbuf_read(&buffer, fd, 0) < 0)
die_errno("git commit-tree: failed to read '%s'",
argv[i]);
if (fd && close(fd))
die_errno("git commit-tree: failed to close '%s'",
argv[i]);
strbuf_complete_line(&buffer);
continue;
}

if (get_sha1(arg, tree_sha1))
die("Not a valid object name %s", arg);
if (got_tree)
die("Cannot give more than one trees");
got_tree = 1;
}

if (strbuf_read(&buffer, 0, 0) < 0)
die_errno("git commit-tree: failed to read");
if (!buffer.len) {
if (strbuf_read(&buffer, 0, 0) < 0)
die_errno("git commit-tree: failed to read");
}

if (commit_tree(buffer.buf, tree_sha1, parents, commit_sha1, NULL)) {
strbuf_release(&buffer);
Expand Down

0 comments on commit 96b8d93

Please sign in to comment.