Skip to content

Commit

Permalink
t8002: make hash size independent
Browse files Browse the repository at this point in the history
Compute the length of an object ID instead of hard-coding 40-based
values.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
bk2204 authored and gitster committed Jul 30, 2020
1 parent a5587b8 commit 98de0b2
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions t/t8002-blame.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ test_description='git blame'
PROG='git blame -c'
. "$TEST_DIRECTORY"/annotate-tests.sh

test_expect_success 'setup' '
hexsz=$(test_oid hexsz)
'

test_expect_success 'blame untracked file in empty repo' '
>untracked &&
test_must_fail git blame untracked
Expand Down Expand Up @@ -105,17 +109,17 @@ test_expect_success 'blame --abbrev=<n> works' '
'

test_expect_success 'blame -l aligns regular and boundary commits' '
check_abbrev 40 -l HEAD &&
check_abbrev 39 -l ^HEAD
check_abbrev $hexsz -l HEAD &&
check_abbrev $((hexsz - 1)) -l ^HEAD
'

test_expect_success 'blame --abbrev=40 behaves like -l' '
check_abbrev 40 --abbrev=40 HEAD &&
check_abbrev 39 --abbrev=40 ^HEAD
test_expect_success 'blame --abbrev with full length behaves like -l' '
check_abbrev $hexsz --abbrev=$hexsz HEAD &&
check_abbrev $((hexsz - 1)) --abbrev=$hexsz ^HEAD
'

test_expect_success '--no-abbrev works like --abbrev=40' '
check_abbrev 40 --no-abbrev
test_expect_success '--no-abbrev works like --abbrev with full length' '
check_abbrev $hexsz --no-abbrev
'

test_expect_success '--exclude-promisor-objects does not BUG-crash' '
Expand Down

0 comments on commit 98de0b2

Please sign in to comment.