Skip to content

Commit

Permalink
Merge branch 'ld/p4-unshelve-fix'
Browse files Browse the repository at this point in the history
The "unshelve" subcommand of "git p4" used incorrectly used
commit^N where it meant to say commit~N to name the Nth generation
ancestor, which has been corrected.

* ld/p4-unshelve-fix:
  git-p4: use HEAD~$n to find parent commit for unshelve
  git-p4 unshelve: adding a commit breaks git-p4 unshelve
  • Loading branch information
gitster committed Sep 25, 2020
2 parents 6c430a6 + 0acbf59 commit 9f4588d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion git-p4.py
Expand Up @@ -4237,7 +4237,7 @@ def findLastP4Revision(self, starting_point):
"""

for parent in (range(65535)):
log = extractLogMessageFromGitCommit("{0}^{1}".format(starting_point, parent))
log = extractLogMessageFromGitCommit("{0}~{1}".format(starting_point, parent))
settings = extractSettingsGitLog(log)
if 'change' in settings:
return settings
Expand Down
5 changes: 4 additions & 1 deletion t/t9832-unshelve.sh
Expand Up @@ -29,8 +29,11 @@ test_expect_success 'init depot' '
)
'

# Create an initial clone, with a commit unrelated to the P4 change
# on HEAD
test_expect_success 'initial clone' '
git p4 clone --dest="$git" //depot/@all
git p4 clone --dest="$git" //depot/@all &&
test_commit -C "$git" "unrelated"
'

test_expect_success 'create shelved changelist' '
Expand Down

0 comments on commit 9f4588d

Please sign in to comment.