Skip to content

Commit

Permalink
ref-filter: make parse_ref_filter_atom a private function
Browse files Browse the repository at this point in the history
The parse_ref_filter_atom() function really shouldn't be
exposed outside of ref-filter.c; its return value is an
integer index into an array that is private in that file.

Since the previous commit removed the sole external caller
(and replaced it with a public function at a more
appropriately level), we can just make this static.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
peff authored and gitster committed Jul 13, 2017
1 parent 18a2565 commit aa8a5d1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion ref-filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ struct atom_value {
/*
* Used to parse format string and sort specifiers
*/
int parse_ref_filter_atom(const char *atom, const char *ep)
static int parse_ref_filter_atom(const char *atom, const char *ep)
{
const char *sp;
const char *arg;
Expand Down
2 changes: 0 additions & 2 deletions ref-filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ struct ref_format {
int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int type);
/* Clear all memory allocated to ref_array */
void ref_array_clear(struct ref_array *array);
/* Parse format string and sort specifiers */
int parse_ref_filter_atom(const char *atom, const char *ep);
/* Used to verify if the given format is correct and to parse out the used atoms */
int verify_ref_format(struct ref_format *format);
/* Sort the given ref_array as per the ref_sorting provided */
Expand Down

0 comments on commit aa8a5d1

Please sign in to comment.