Skip to content

Commit

Permalink
unpack-trees: rename "gently" flag to "quiet"
Browse files Browse the repository at this point in the history
The gently flag was added in 17e4642 (Add flag to make unpack_trees()
not print errors. - 2008-02-07) to suppress error messages. The name
"gently" does not quite express that. Granted, being quiet is gentle but
it could mean not performing some other actions. Rename the flag to
"quiet" to be more on point.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
pclouds authored and gitster committed Mar 24, 2019
1 parent 191e9d2 commit b165fac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion builtin/checkout.c
Expand Up @@ -700,7 +700,7 @@ static int merge_working_tree(const struct checkout_opts *opts,
topts.initial_checkout = is_cache_unborn();
topts.update = 1;
topts.merge = 1;
topts.gently = opts->merge && old_branch_info->commit;
topts.quiet = opts->merge && old_branch_info->commit;
topts.verbose_update = opts->show_progress;
topts.fn = twoway_merge;
if (opts->overwrite_ignore) {
Expand Down
6 changes: 3 additions & 3 deletions unpack-trees.c
Expand Up @@ -219,7 +219,7 @@ static int add_rejected_path(struct unpack_trees_options *o,
enum unpack_trees_error_types e,
const char *path)
{
if (o->gently)
if (o->quiet)
return -1;

if (!o->show_all_errors)
Expand Down Expand Up @@ -1042,7 +1042,7 @@ static int unpack_nondirectories(int n, unsigned long mask,
static int unpack_failed(struct unpack_trees_options *o, const char *message)
{
discard_index(&o->result);
if (!o->gently && !o->exiting_early) {
if (!o->quiet && !o->exiting_early) {
if (message)
return error("%s", message);
return -1;
Expand Down Expand Up @@ -2343,7 +2343,7 @@ int bind_merge(const struct cache_entry * const *src,
return error("Cannot do a bind merge of %d trees",
o->merge_size);
if (a && old)
return o->gently ? -1 :
return o->quiet ? -1 :
error(ERRORMSG(o, ERROR_BIND_OVERLAP),
super_prefixed(a->name),
super_prefixed(old->name));
Expand Down
2 changes: 1 addition & 1 deletion unpack-trees.h
Expand Up @@ -56,7 +56,7 @@ struct unpack_trees_options {
diff_index_cached,
debug_unpack,
skip_sparse_checkout,
gently,
quiet,
exiting_early,
show_all_errors,
dry_run;
Expand Down

0 comments on commit b165fac

Please sign in to comment.