Skip to content

Commit

Permalink
submodule: eliminate unused parameters from print_submodule_summary()
Browse files Browse the repository at this point in the history
Eliminate the parameters 'missing_{src,dst}' from the
'print_submodule_summary()' function call since they are not used
anywhere in the function.

Reported-by: Jeff King <peff@peff.net>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
periperidip authored and gitster committed Aug 25, 2020
1 parent e83e333 commit e0f7ae5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions builtin/submodule--helper.c
Expand Up @@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path,
static void print_submodule_summary(struct summary_cb *info, char* errmsg,
int total_commits, const char *displaypath,
const char *src_abbrev, const char *dst_abbrev,
int missing_src, int missing_dst,
struct module_cb *p)
{
if (p->status == 'T') {
Expand Down Expand Up @@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info,

print_submodule_summary(info, errmsg, total_commits,
displaypath, src_abbrev,
dst_abbrev, missing_src,
missing_dst, p);
dst_abbrev, p);

free(displaypath);
free(src_abbrev);
Expand Down

0 comments on commit e0f7ae5

Please sign in to comment.