Skip to content

Commit

Permalink
Move definition of enum branch_track from cache.h to branch.h
Browse files Browse the repository at this point in the history
'branch_track' feels more closely related to branching, and it is
needed later in branch.h; rather than #include'ing cache.h in branch.h
for this small enum, just move the enum and the external declaration
for git_branch_track to branch.h.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
newren authored and gitster committed Aug 15, 2018
1 parent 1731310 commit e730b81
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
11 changes: 11 additions & 0 deletions branch.h
Expand Up @@ -3,6 +3,17 @@

struct strbuf;

enum branch_track {
BRANCH_TRACK_UNSPECIFIED = -1,
BRANCH_TRACK_NEVER = 0,
BRANCH_TRACK_REMOTE,
BRANCH_TRACK_ALWAYS,
BRANCH_TRACK_EXPLICIT,
BRANCH_TRACK_OVERRIDE
};

extern enum branch_track git_branch_track;

/* Functions for acting on the information about branches. */

/*
Expand Down
10 changes: 0 additions & 10 deletions cache.h
Expand Up @@ -919,15 +919,6 @@ enum log_refs_config {
};
extern enum log_refs_config log_all_ref_updates;

enum branch_track {
BRANCH_TRACK_UNSPECIFIED = -1,
BRANCH_TRACK_NEVER = 0,
BRANCH_TRACK_REMOTE,
BRANCH_TRACK_ALWAYS,
BRANCH_TRACK_EXPLICIT,
BRANCH_TRACK_OVERRIDE
};

enum rebase_setup_type {
AUTOREBASE_NEVER = 0,
AUTOREBASE_LOCAL,
Expand All @@ -944,7 +935,6 @@ enum push_default_type {
PUSH_DEFAULT_UNSPECIFIED
};

extern enum branch_track git_branch_track;
extern enum rebase_setup_type autorebase;
extern enum push_default_type push_default;

Expand Down
1 change: 1 addition & 0 deletions config.c
Expand Up @@ -6,6 +6,7 @@
*
*/
#include "cache.h"
#include "branch.h"
#include "config.h"
#include "repository.h"
#include "lockfile.h"
Expand Down
1 change: 1 addition & 0 deletions environment.c
Expand Up @@ -8,6 +8,7 @@
* are.
*/
#include "cache.h"
#include "branch.h"
#include "repository.h"
#include "config.h"
#include "refs.h"
Expand Down

0 comments on commit e730b81

Please sign in to comment.