Skip to content

Commit

Permalink
Merge branch 'jk/make-protocol-v2-the-default'
Browse files Browse the repository at this point in the history
The transport protocol v2 has become the default again.

* jk/make-protocol-v2-the-default:
  protocol: re-enable v2 protocol by default
  • Loading branch information
gitster committed Sep 29, 2020
2 parents b28919c + eb04975 commit e76ae33
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
4 changes: 0 additions & 4 deletions Documentation/config/feature.txt
Expand Up @@ -14,10 +14,6 @@ feature.experimental::
+
* `fetch.negotiationAlgorithm=skipping` may improve fetch negotiation times by
skipping more commits at a time, reducing the number of round trips.
+
* `protocol.version=2` speeds up fetches from repositories with many refs by
allowing the client to specify which refs to list before the server lists
them.

feature.manyFiles::
Enable config options that optimize for repos with many files in the
Expand Down
3 changes: 1 addition & 2 deletions Documentation/config/protocol.txt
Expand Up @@ -48,8 +48,7 @@ protocol.version::
If set, clients will attempt to communicate with a server
using the specified protocol version. If the server does
not support it, communication falls back to version 0.
If unset, the default is `0`, unless `feature.experimental`
is enabled, in which case the default is `2`.
If unset, the default is `2`.
Supported versions:
+
--
Expand Down
6 changes: 1 addition & 5 deletions protocol.c
Expand Up @@ -17,7 +17,6 @@ static enum protocol_version parse_protocol_version(const char *value)
enum protocol_version get_protocol_version_config(void)
{
const char *value;
int val;
const char *git_test_k = "GIT_TEST_PROTOCOL_VERSION";
const char *git_test_v;

Expand All @@ -31,9 +30,6 @@ enum protocol_version get_protocol_version_config(void)
return version;
}

if (!git_config_get_bool("feature.experimental", &val) && val)
return protocol_v2;

git_test_v = getenv(git_test_k);
if (git_test_v && *git_test_v) {
enum protocol_version env = parse_protocol_version(git_test_v);
Expand All @@ -43,7 +39,7 @@ enum protocol_version get_protocol_version_config(void)
return env;
}

return protocol_v0;
return protocol_v2;
}

enum protocol_version determine_protocol_version_server(void)
Expand Down

0 comments on commit e76ae33

Please sign in to comment.