Skip to content

Commit

Permalink
Merge branch 'jd/prompt-show-conflict' into jch
Browse files Browse the repository at this point in the history
The bash prompt (in contrib/) learned to optionally indicate when
the index is unmerged.

* jd/prompt-show-conflict:
  git-prompt: show presence of unresolved conflicts at command prompt
  • Loading branch information
gitster committed Aug 25, 2022
2 parents b028d76 + e03acd0 commit fb3cf8e
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
12 changes: 11 additions & 1 deletion contrib/completion/git-prompt.sh
Expand Up @@ -84,6 +84,10 @@
# single '?' character by setting GIT_PS1_COMPRESSSPARSESTATE, or omitted
# by setting GIT_PS1_OMITSPARSESTATE.
#
# If you would like to see a notification on the prompt when there are
# unresolved conflicts, set GIT_PS1_SHOWCONFLICTSTATE to "yes". The
# prompt will include "|CONFLICT".
#
# If you would like to see more information about the identity of
# commits checked out as a detached HEAD, set GIT_PS1_DESCRIBE_STYLE
# to one of these values:
Expand Down Expand Up @@ -508,6 +512,12 @@ __git_ps1 ()
r="$r $step/$total"
fi

local conflict="" # state indicator for unresolved conflicts
if [[ "${GIT_PS1_SHOWCONFLICTSTATE}" == "yes" ]] &&
[[ $(git ls-files --unmerged 2>/dev/null) ]]; then
conflict="|CONFLICT"
fi

local w=""
local i=""
local s=""
Expand Down Expand Up @@ -572,7 +582,7 @@ __git_ps1 ()
fi

local f="$h$w$i$s$u$p"
local gitstring="$c$b${f:+$z$f}${sparse}$r${upstream}"
local gitstring="$c$b${f:+$z$f}${sparse}$r${upstream}${conflict}"

if [ $pcmode = yes ]; then
if [ "${__git_printf_supports_v-}" != yes ]; then
Expand Down
16 changes: 16 additions & 0 deletions t/t9903-bash-prompt.sh
Expand Up @@ -759,4 +759,20 @@ test_expect_success 'prompt - hide if pwd ignored - inside gitdir' '
test_cmp expected "$actual"
'

test_expect_success 'prompt - conflict indicator' '
printf " (main|CONFLICT)" >expected &&
echo "stash" >file &&
git stash &&
test_when_finished "git stash drop" &&
echo "commit" >file &&
git commit -m "commit" file &&
test_when_finished "git reset --hard HEAD~" &&
test_must_fail git stash apply &&
(
GIT_PS1_SHOWCONFLICTSTATE="yes" &&
__git_ps1 >"$actual"
) &&
test_cmp expected "$actual"
'

test_done

0 comments on commit fb3cf8e

Please sign in to comment.