New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: also update offset for features without values #1091
Conversation
9ad0dad
to
dcbb05d
Compare
The one remaining failure looks like a flake (didn't fail on previous runs, looks unrelated to this change, etc.): |
/preview |
Preview email sent as pull.1091.git.git.1631970778131.gitgitgadget@gmail.com |
/submit |
Submitted as pull.1091.git.git.1631970872884.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Taylor Blau wrote (reply to this):
|
On the Git mailing list, "brian m. carlson" wrote (reply to this):
|
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Taylor Blau wrote (reply to this):
|
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
User |
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
This branch is now known as |
This patch series was integrated into seen via e19ee05. |
This patch series was integrated into seen via c0d39ae. |
There was a status update in the "New Topics" section about the branch Protocol v0 clients can get stuck parsing a malformed feature line. Will merge to 'next'. |
This patch series was integrated into seen via 95480e7. |
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Jeff King wrote (reply to this):
|
This patch series was integrated into seen via c760471. |
There was a status update in the "Cooking" section about the branch Protocol v0 clients can get stuck parsing a malformed feature line. Will merge to 'next'. |
On the Git mailing list, Andrzej Hunt wrote (reply to this):
|
On the Git mailing list, Andrzej Hunt wrote (reply to this):
|
/preview |
Preview email sent as pull.1091.v2.git.git.1632669806284.gitgitgadget@gmail.com |
parse_feature_value() takes an offset, and uses it to seek past the point in features_list that we've already seen. However if the feature being searched for does not specify a value, the offset is not updated. Therefore if we call parse_feature_value() in a loop on a value-less feature, we'll keep on parsing the same feature over and over again. This usually isn't an issue: there's no point in using next_server_feature_value() to search for repeated instances of the same capability unless that capability typically specifies a value - but a broken server could send a response that omits the value for a feature even when we are expecting a value. Therefore we add an offset update calculation for the no-value case, which helps ensure that loops using next_server_feature_value() will always terminate. next_server_feature_value(), and the offset calculation, were first added in 2.28 in 2c6a403 (connect: add function to parse multiple v1 capability values, 2020-05-25). Thanks to Peff for authoring the test. Co-authored-by: Jeff King <peff@peff.net> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Andrzej Hunt <andrzej@ahunt.org>
/submit |
Submitted as pull.1091.v2.git.git.1632671913693.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Jeff King wrote (reply to this):
|
This patch series was integrated into seen via c3553e1. |
There was a status update in the "Cooking" section about the branch Protocol v0 clients can get stuck parsing a malformed feature line. Will merge to 'next'. |
This patch series was integrated into seen via 08ab684. |
This patch series was integrated into seen via c710660. |
This patch series was integrated into seen via bcb86b1. |
This patch series was integrated into next via 93a4572. |
There was a status update in the "Cooking" section about the branch Protocol v0 clients can get stuck parsing a malformed feature line. Will merge to 'master'. |
This patch series was integrated into seen via 3a757d0. |
This patch series was integrated into next via 3a757d0. |
This patch series was integrated into master via 3a757d0. |
Closed via 3a757d0. |
V2 incorporates Peff's test and test stability improvements, and attempts to improve the commit message.
ATB,
Andrzej
CC: Jeff King peff@peff.net
CC: Taylor Blau me@ttaylorr.com
CC: brian m . carlson sandals@crustytoothpaste.net
cc: Eric Sunshine sunshine@sunshineco.com