Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t64xx: convert 'test_create_repo' to 'git init' #1303

Closed

Conversation

newren
Copy link
Contributor

@newren newren commented Jul 29, 2022

As promised[1].

This patch merges cleanly with main & next & seen, and there are no current in-flight topics that add a test_create_repo call to the t64xx range of tests. This patch also gets rid of 37% of the test_create_repo calls in the entire testsuite.

Changes since v1:

  • Tweaked commit message
  • Added Dscho's Reviewed-by

[1] https://lore.kernel.org/git/CABPp-BEcojvfeuhp7rSi-O+9oEu4KpwPDwbKS-MiD1qCKde-CA@mail.gmail.com/

cc: Johannes Schindelin Johannes.Schindelin@gmx.de

@newren newren force-pushed the nuke_test_create_repo_in_merge_tests branch from 3ad3547 to ad1c38c Compare July 29, 2022 04:50
@newren
Copy link
Contributor Author

newren commented Aug 20, 2022

/submit

@gitgitgadget-git
Copy link

Submitted as pull.1303.git.git.1661034837118.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v1

To fetch this version to local tag pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v1

@gitgitgadget-git
Copy link

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Elijah,

On Sat, 20 Aug 2022, Elijah Newren via GitGitGadget wrote:

> From: Elijah Newren <newren@gmail.com>
>
> As promised[1], convert the merge-specific tests over to using 'git
> init' instead of 'test_create_repo'.
>
> [1] https://lore.kernel.org/git/CABPp-BEcojvfeuhp7rSi-O+9oEu4KpwPDwbKS-MiD1qCKde-CA@mail.gmail.com/
>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Large patch, but easy to review, and the commit message is clear (and
despite being short, follows the structure outlined in
https://github.blog/2022-06-30-write-better-commits-build-better-projects/:
Intent, Context, Implementation and Justification).

Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Thank you,
Dscho

@gitgitgadget-git
Copy link

User Johannes Schindelin <Johannes.Schindelin@gmx.de> has been added to the cc: list.

Convert the merge-specific tests (those in the t64xx range) over to
using 'git init' instead of 'test_create_repo'.

Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Elijah Newren <newren@gmail.com>
@newren newren changed the title t64??: convert 'test_create_repo' to 'git init' t64xx: convert 'test_create_repo' to 'git init' Aug 25, 2022
@newren newren force-pushed the nuke_test_create_repo_in_merge_tests branch from ad1c38c to cd2ebd9 Compare August 25, 2022 16:59
@newren
Copy link
Contributor Author

newren commented Aug 26, 2022

/submit

@gitgitgadget-git
Copy link

Submitted as pull.1303.v2.git.git.1661485759789.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v2

To fetch this version to local tag pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v2:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1303/newren/nuke_test_create_repo_in_merge_tests-v2

@gitgitgadget-git
Copy link

This branch is now known as en/test-without-test-create-repo.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 3ec05cd.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 7422cec.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 604936f.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 4f80f48.

@gitgitgadget-git
Copy link

There was a status update in the "New Topics" section about the branch en/test-without-test-create-repo on the Git mailing list:

Test clean-up.

Will merge to 'master'.
source: <pull.1303.v2.git.git.1661485759789.gitgitgadget@gmail.com>

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 4ebd648.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 667e183.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via fcbc874.

@gitgitgadget-git
Copy link

This patch series was integrated into master via fcbc874.

@gitgitgadget-git
Copy link

This patch series was integrated into next via fcbc874.

@gitgitgadget-git
Copy link

Closed via fcbc874.

@newren newren deleted the nuke_test_create_repo_in_merge_tests branch September 21, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant