-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: remove redundant notes_ref check #1400
Conversation
There are issues in commit 6f4a6b9: |
Earlier in the init_notes function, notes_ref is guaranteed to be the default ref if it is NULL by then, making future checks for notes_ref to be redundant, and xstrdup_or_null can just be xstrdup. Signed-off-by: Seija Kijin <doremylover123@gmail.com>
/submit |
Submitted as pull.1400.git.git.1671399699603.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This patch series was integrated into seen via 1c46908. |
This patch series was integrated into seen via d83ddab. |
This patch series was integrated into seen via 1f4ce63. |
This patch series was integrated into seen via 474676c. |
This patch series was integrated into next via 9500384. |
This patch series was integrated into seen via 8894347. |
This patch series was integrated into seen via 469783e. |
This patch series was integrated into seen via 25c60c2. |
This patch series was integrated into seen via 1d3f0a9. |
This patch series was integrated into seen via f357d46. |
This patch series was integrated into master via f357d46. |
This patch series was integrated into next via f357d46. |
Closed via f357d46. |
Earlier in the init_notes function, notes_ref is guaranteed to be the default ref if it is NULL by then,
making future checks for notes_ref to be redundant, and xstrdup_or_null can just be xstrdup.