Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: remove redundant notes_ref check #1400

Closed
wants to merge 1 commit into from

Conversation

AtariDreams
Copy link

Earlier in the init_notes function, notes_ref is guaranteed to be the default ref if it is NULL by then,
making future checks for notes_ref to be redundant, and xstrdup_or_null can just be xstrdup.

@gitgitgadget-git
Copy link

There are issues in commit 6f4a6b9:
git: remove redundant notes_ref check
Commit not signed off

Earlier in the init_notes function, notes_ref is guaranteed
to be the default ref if it is NULL by then,
making future checks for notes_ref to be redundant,
and xstrdup_or_null can just be xstrdup.

Signed-off-by: Seija Kijin <doremylover123@gmail.com>
@AtariDreams
Copy link
Author

/submit

@gitgitgadget-git
Copy link

Submitted as pull.1400.git.git.1671399699603.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1400/AtariDreams/xstrdup-v1

To fetch this version to local tag pr-git-1400/AtariDreams/xstrdup-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1400/AtariDreams/xstrdup-v1

@Mezzika

This comment was marked as off-topic.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 1c46908.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via d83ddab.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 1f4ce63.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 474676c.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 9500384.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 8894347.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 469783e.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 25c60c2.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via 1d3f0a9.

@gitgitgadget-git
Copy link

This patch series was integrated into seen via f357d46.

@gitgitgadget-git
Copy link

This patch series was integrated into master via f357d46.

@gitgitgadget-git
Copy link

This patch series was integrated into next via f357d46.

@gitgitgadget-git
Copy link

Closed via f357d46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants