curl: resolve deprecated curl declarations #1435
Conversation
AtariDreams
force-pushed
the
curl
branch
9 times, most recently
from
75b0bf8
to
dd6dccd
Compare
|
There are issues in commit dd6dccd: |
AtariDreams
force-pushed
the
curl
branch
7 times, most recently
from
24b9387
to
d84e7e0
Compare
|
/submit |
|
Submitted as pull.1435.git.git.1673983640663.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
/submit |
|
Submitted as pull.1435.v2.git.git.1673984591615.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
AtariDreams
force-pushed
the
curl
branch
2 times, most recently
from
8098816
to
14ca56f
Compare
|
/submit |
|
Submitted as pull.1435.v3.git.git.1673985725868.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
/submit |
|
Submitted as pull.1435.v4.git.git.1673986152672.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
/submit |
|
Submitted as pull.1435.v5.git.git.1673986764553.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
/submit |
|
Submitted as pull.1435.v6.git.git.1673986937738.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
/submit |
|
Submitted as pull.1435.v7.git.git.1673987583356.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
Fix CI-Alpine build by replacing deprecated declarations with their suggested replacements Note that this required changing the callbacks of functions because the replacement for these deprecations require a different function signature for the callback and different parameters. Every change done was made as to minimize changed behavior as well as get the CI to pass again. Signed-off-by: Seija Kijin <doremylover123@gmail.com>
|
/submit |
|
Submitted as pull.1435.v8.git.git.1673991669894.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This patch series was integrated into seen via c52b021. |
|
This patch series was integrated into next via e3ead5f. |
|
On the Git mailing list, Junio C Hamano wrote (reply to this): "Rose via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1435%2FAtariDreams%2Fcurl-v8
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1435/AtariDreams/curl-v8
> Pull-Request: https://github.com/git/git/pull/1435
>
> Range-diff vs v7:
>
> 1: 23094afb2e6 ! 1: 5e44592695e curl: resolve deprecated curl declarations
> ...
Please stop throwing in quick succession so many unsolicited
iterations of the same topic at the list, before waiting for reviews
from others.
I do not mean "after you sent an initial revision out, even if you
find problems in it, do not send updates in for a while". I mean
"do not send out that initial revision out, before you spend enough
time reading it to find these problems in it you found in, like you
did in these previous topics."
In other words, reviewing your own patches to carefully find
mistakes and correcting them is VERY GOOD, but rather than doing so
in public, you can do so in private before sending the patches out
to polish them sufficiently so that you won't find more trivial
problems [*]. Prepare patches in private and pretend to be a more
perfect human with fewer trivial mistakes ;-).
Note. And you shouldn't be offended by me saying "trivial"; they
were found by yourself in a few minutes to a few hours after
you sent out the previous iteration.
That way, you'd save yourself from public embarrassment and also
save reviewer time.
Thanks.
P.S. Doesn't Peff's 3-patch series already solve the same issue this
patch is trying to address? |
|
This patch series was integrated into seen via 10925f5. |
|
This patch series was integrated into master via 10925f5. |
|
This patch series was integrated into next via 10925f5. |
|
Closed via 10925f5. |
Fix CI-Alpine build by replacing deprecated
declarations with their suggested replacements
Signed-off-by: Seija Kijin doremylover123@gmail.com