setup: update error message to be more meaningful #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message shown when a flag is found when expecting a
filename wasn't clear as it didn't communicate what was wrong
using the 'suitable' words in *all* cases.
$ git ls-files
README.md
test-file
Correct case,
$ git rev-parse README.md --flags
README.md
--flags
fatal: bad flag '--flags' used after filename
Incorrect case,
$ git grep "some random regex" -n
fatal: bad flag '-n' used after filename
The above case is incorrect as "some random regex" isn't a filename
in this case.
Change the error message to be general and communicative. This results
in the following output,
$ git rev-parse README.md --flags
README.md
--flags
fatal: option '--flags' must come before non-option arguments
$ git grep "some random regex" -n
fatal: option '-n' must come before non-option arguments
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
|
@sivaraam sent this commit (5800c63...b7cd847) as a patch to the mailing list with submitGit - here on public-inbox, MARC |
derrickstolee
pushed a commit
to derrickstolee/git
that referenced
this pull request
Jul 22, 2021
Add instructions for `apt-get` install to `README`
derrickstolee
pushed a commit
to derrickstolee/git
that referenced
this pull request
Aug 10, 2021
Add instructions for `apt-get` install to `README`
derrickstolee
pushed a commit
to derrickstolee/git
that referenced
this pull request
Aug 15, 2021
Add instructions for `apt-get` install to `README`
derrickstolee
pushed a commit
to derrickstolee/git
that referenced
this pull request
Aug 17, 2021
Add instructions for `apt-get` install to `README`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message shown when a flag is found when expecting a
filename wasn't clear as it didn't communicate what was wrong
using the 'suitable' words in all cases.
Correct case,
Incorrect case,
The above case is incorrect as "some random regex" isn't a filename
in this case.
Change the error message to be general and communicative. This results
in the following output,
Signed-off-by: Kaartic Sivaraam kaarticsivaraam91196@gmail.com