Expose metrics for Prometheus Monitoring Framework #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goettl79
force-pushed
the
PROMETHEUS
branch
2 times, most recently
from
e9933d2
to
f2d822e
Compare
/metrics was already taken
Enabled default log4j metrics collector. The number of log4j log entries will be counted. This enable the following measurable metrics (captured after clean startup gitblit):
# HELP log4j_appender_total Log4j log statements at various log levels
# TYPE log4j_appender_total counter
log4j_appender_total{level="debug",} 0.0
log4j_appender_total{level="warn",} 1.0
log4j_appender_total{level="trace",} 0.0
log4j_appender_total{level="error",} 0.0
log4j_appender_total{level="fatal",} 0.0
log4j_appender_total{level="info",} 82.0
Added metrics for: 1. gitblit_garbage_collects_total 2. gitblit_ldap_sync_latency_seconds. Add gitblit_ prefix to gitblit specific metrics
.) http_request_duration_seconds (histogram) -> Labels (path,method) .) http_requests_total (counter) -> Labels (path,method,status) Where path is the REST path of the ressource, method is the HTTP method (GET,PUT..) and status is the HTTP response code (2xx, 3xx ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gitblit : With this pull request prometheus monitoring metrics are exposed by default. I enabled default metrics for JVM, log4j and custom metrics for git garbage collection and ldap sync latency. The metrics exposed are not complete, so feedback here would be great. Metrics exposed are biased to my needs.