Fixes the 30 seconds timeout when cloning over HTTP #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server.httpTimeout setting to allow cloning big repositories over HTTP. This change fixes the java.util.concurrent.TimeoutException issue described in https://groups.google.com/d/topic/gitblit/UvDC48NpmF4/discussion .
gitblit
requested changes
Jun 1, 2017
| # | ||
| # SINCE 1.9.0 | ||
| # RESTART REQUIRED | ||
| server.httpTimeout = 30000 |
There was a problem hiding this comment.
How about server.httpIdleTimeout
| @@ -2134,6 +2134,13 @@ server.requireClientCertificates = false | |||
| # RESTART REQUIRED | |||
| server.shutdownPort = 8081 | |||
|
|
|||
| # Timeout (in milliseconds) for http and https requests | |||
There was a problem hiding this comment.
How about Http idle timeout (in milliseconds)...
|
I've made the changes, I can't figure out if there's anything else that I need to do to have them applied to the pull request however. Let me know if I need to drop this pull request and create a new one. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
server.httpTimeoutsetting to allow cloning big repositories over HTTP. This change fixes the java.util.concurrent.TimeoutException issue described in https://groups.google.com/d/topic/gitblit/UvDC48NpmF4/discussion .