Add support nested groups on the Repositories page #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks to this dependency, one can start gitblit with java 9 without using deprecated internal module --add-modules java.activation
|
Just got a task to realize similar functionality. Nice to see it done! |
flaix
added a commit
to flaix/gitblit
that referenced
this pull request
Jun 15, 2019
Fix for gitblit-org#725. Also covers gitblit-org#527. This is a squashed commit of the following commits, merging and closing pull request gitblit-org#1267: commit 55fee41 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 17:19:53 2017 +0100 declared local variable final to fix travis build commit 131e4d1 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 14:11:55 2017 +0100 fix formatting (use tab for identation) commit 8da5f6d Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 13:45:39 2017 +0100 Add repositoryListType tree. Addresses gitblit-org#725, 527 and includes gitblit-org#1224 commit 6c06165 Merge: f365daa 40ee965 Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:19:08 2017 +0100 Merge remote-tracking branch 'collapsible/ticket/527' into 725_nested_repos commit f365daa Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:10:24 2017 +0100 first working version of tree model
|
What would you think about listing repositories first?
Leaving out the "guard rails" would look cleaner, but with many folders it might get difficult to see what group a repository belongs to. On the other hand, this is the opposite sorting to what one is used from a file explorer. |
|
I like your approach a lot. looks much better in my opinion 👍 |
|
Closed by a squash merge to master in commit 0bace7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #725.
This includes #1224 from @ybosy, because a lot of the code of it was reusable.
Also covers #527
(Panel contains a lot of copy-paste code from RepositoriesPanel :( But this way I was able to keep the original RepositoriesPanel without changing it a lot. ...this could be done a lot easier after a wicket upgrade in my opinion ;))