Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of the repository is not displayed #591

Closed
gitblit opened this issue Aug 12, 2015 · 14 comments
Closed

Size of the repository is not displayed #591

gitblit opened this issue Aug 12, 2015 · 14 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 295

What steps will reproduce the problem?
1. Access the summary page of a repository


What is the expected output? What do you see instead?
Size of the repository should be displayed.
Gitblit logs show that size seems to have been properly calculated:
"161 repository sizes calculated in 3,906 msecs"
However, size line is blank for all of them (see screenshot)

What version of the product are you using? On what operating system?
Gitblit 1.3.2 on Windows 2003 Server


Reported by h.questroy on 2013-08-13 11:44:56


- _Attachment: screenshot.png
![screenshot.png](https://storage.googleapis.com/google-code-attachments/gitblit/issue-295/comment-0/screenshot.png)_
@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Sorry, I meant Gitblit 1.3.1

Reported by h.questroy on 2013-08-13 11:46:26

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

What do you see in the repositories list?

Reported by James.Moger on 2013-08-13 11:49:40

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

No size either

Reported by h.questroy on 2013-08-13 12:01:16

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hmm.  Suspicious.  Confirm this setting in gitblit.properties:

web.showRepositorySizes = true

Reported by James.Moger on 2013-08-13 12:11:56

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I confirm

Reported by h.questroy on 2013-08-13 12:14:00

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Oups ...
I made a msiatke, the size is properly displayed in the repositories list.

So, it's only on the repository page that it is not displayed as shown by the screenshot.

Sorry for the confusion.

Reported by h.questroy on 2013-08-13 12:15:44

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

What about this setting?

git.cacheRepositoryList = true

Did you leave it as the default: true?

Reported by James.Moger on 2013-08-13 12:27:32

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

No.
I set it to false.

Reported by h.questroy on 2013-08-13 12:52:22

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Set it to true and let me know if that works.

I don't recommend disabling caching.

Reported by James.Moger on 2013-08-13 12:55:53

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I set the property to true and restarted Gitblit service.
The size still does not show up in repository's page.

Reported by h.questroy on 2013-08-13 13:02:11

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Bizarre.  I can't explain why you see sizes on the repo list but not the summary page.

I'll try to make time later to review this more carefully.

Reported by James.Moger on 2013-08-13 13:23:11

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

OK.

Reported by h.questroy on 2013-08-13 13:25:02

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I could not reproduce this myself.  However,  I can see a scenario where the summary
page could get a repository model without a properly set size.  I have revised and
simplified the when repo size calculation occurs and I believe this change will fix
your issue.

Reported by James.Moger on 2013-08-16 13:51:13

  • Status changed: Queued
  • Labels added: Milestone-1.3.2

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fixed/change deployed in v1.3.2.

Reported by James.Moger on 2013-08-22 17:17:52

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.3.2 milestone Dec 13, 2016
@flaix flaix added this to the 1.3.2 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants