Ticket Reference handling #1048 #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
paulsputer
commented
Apr 11, 2016
paulsputer
commented
- Supports referencing:
- from other tickets via comments
- from commits on other branches
Example showing reference by commit
|
|
@gitblit could you cast an eye over this and share your thoughts? |
|
I will cast my eye. Trying to make time. |
|
Thoughts...
|
|
Thanks James, (1) will do, (2) very true, I tried to use the lowest level lozenge but still looks a bit too much, I'll make those fixes and post back. Are you happy with the temporary TicketLink and persisted Reference structures? I'm not sure if there's any cleaner alternative. |
paulsputer
force-pushed
the
1048-TicketReferences
branch
from
0536531
to
2c91b98
Compare
+ Supports referencing: + Tickets from other tickets via comments + Tickets from commits on any branch + Common TicketLink class used for both commits and tickets + TicketLink is temporary and persisted to ticket as a Reference + Support deletion of ticket references + Rebasing patchsets/branches will generate new references + Deleting old patchsets/branches will remove the relevant references + Substantial testing of use cases + With and without patchsets, deleting, amending + BranchTicketService used during testing to allow end-to-end ref testing + Relocated common git helper functions to JGitUtils
paulsputer
force-pushed
the
1048-TicketReferences
branch
from
5f4bfa3
to
c2188a8
Compare
|
ok @gitblit can you take another look at this and see if there's anything else we need to address on referencing in this PR? It's getting a bit larger than I was anticipating, then again half of it is testing the different use cases. |
|
Here's the updated UI |
+ Multiple commits in a single push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.