Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Select All with Ctrl+A no longer limits bounds to the codeblock #29

Closed
Nantris opened this issue Nov 17, 2017 · 2 comments
Closed

Select All with Ctrl+A no longer limits bounds to the codeblock #29

Nantris opened this issue Nov 17, 2017 · 2 comments
Labels
bug

Comments

@Nantris
Copy link

Nantris commented Nov 17, 2017

Using Ctrl+A selects all contents in Slate now, rather than just the codeblock content.
@Nantris
Copy link
Author

Nantris commented Nov 19, 2017 •
edited
Loading

The cause of this issue is the use of event.metaKey in onKeyDown.js

event.metaKey is false when using the Ctrl key in Windows: ianstormtaylor/slate#1422

event.metaKey is the Windows key in some browsers. In Firefox I don't know if metaKey can be triggered at all on Windows.

@Nantris Nantris mentioned this issue Nov 19, 2017
Closed
@Soreine Soreine added the bug label Nov 19, 2017
@Nantris
Copy link
Author

Nantris commented Nov 20, 2017

I've submitted a PR for this, #30

@Soreine Soreine mentioned this issue Nov 27, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Soreine @Nantris