-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples use event.metaKey to capture ctrlKey, but on Windows this does not work #1422
Comments
I might be mistaken, but I believe metaKey is the Windows button itself: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey Unless you're using Firefox > 48 |
Correct, but on Mac it's the Command Key (the Clover), which is used in place of Ctrl in Mac often if I'm not mistaken, for example Command+C to copy instead of Ctrl+C. Someone correct me if I'm wrong. |
I realize by the way that I wasn't clear. This is only an issue in the guides such as: https://docs.slatejs.org/walkthroughs/using-plugins not in the |
What we did in |
This should be fixed by #1601 |
Whoops. Really dropped the ball here. This was specifically about the walkthrough using Do the examples as written (now using |
Yep no worries! |
On Windows event.metaKey is false when using the
Ctrl
key. This leads to the plugin examples not working on Windows and the same for any other code copying this method: https://docs.slatejs.org/walkthroughs/using-pluginsThe text was updated successfully, but these errors were encountered: