Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] - addSection missing return type #833

Closed
1 of 4 tasks
dylang opened this issue Aug 27, 2020 · 2 comments
Closed
1 of 4 tasks

[typescript] - addSection missing return type #833

dylang opened this issue Aug 27, 2020 · 2 comments
Assignees
Milestone

Comments

@dylang
Copy link

dylang commented Aug 27, 2020

Category

  • Enhancement
  • Bug
  • Question
  • Documentation gap/issue

Version

Please specify what version of the library you are using: [master]

Please specify what version(s) of PowerPoint you are targeting: [n/a]

Expected / Desired Behavior / Question

Expect to have a return type here: https://github.com/gitbrent/PptxGenJS/blob/master/types/index.d.ts#L87

Observed Behavior

node_modules/pptxgenjs/types/index.d.ts:87:2 - error TS7010: 'addSection', 
which lacks return-type annotation, implicitly has an 'any' return type.

87  addSection(section: PptxGenJS.SectionProps)
    ~~~~~~~~~~

Found 1 error.

Steps to Reproduce

Type check project with latest PptxGenJS as a depedency and skipLibChecks: false.

@gitbrent gitbrent self-assigned this Aug 28, 2020
@gitbrent gitbrent added this to the 3.4.0 milestone Aug 28, 2020
gitbrent added a commit that referenced this issue Aug 28, 2020
gitbrent added a commit that referenced this issue Aug 28, 2020
@gitbrent
Copy link
Owner

Thanks @dylang !

wyozi added a commit to wyozi/react-pptx that referenced this issue Aug 29, 2020
@praveenpuglia
Copy link

Is there a workaround for this that I can use while 3.4.0 is released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants