fix: line break logic #839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not clear why this file is not formatted. On its own to avoid noise.
This adds the failing tests for bold and linebreaks
eval use doesn't work with some debuggers.
|
@gitbrent updated PR with fix for the issue. This is good to merge. |
|
Can a test case for this issue be provided? |
gnomical
added a commit
to Vigilant-LLC/PptxGenJS
that referenced
this pull request
Jul 2, 2021
This is part of pull request gitbrent#839 in the source repo. applying in our fork until the source repo gets to managing its pull requests.
|
Closing due to age. Text/line-break algorithm has been completely rewritten in the past year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes line break logic when formatting changes
Supplies requested previously failing test case for #751
The issue was that line breaks are inserted when switching on and off bold formatting.