Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle branch which contains / properly in branch settings #2519

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Handle branch which contains / properly in branch settings #2519

merged 1 commit into from
Aug 22, 2020

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Aug 22, 2020

Fixes #1785

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

@takezoe takezoe added the bug label Aug 22, 2020
@takezoe takezoe added this to the 4.35.0 milestone Aug 22, 2020
@takezoe takezoe requested a review from SIkebe August 22, 2020 16:12
@takezoe
Copy link
Member Author

takezoe commented Aug 22, 2020 •
edited
Loading

@pinpikokun @SIkebe This will fix #1785

SIkebe
SIkebe approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@SIkebe SIkebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SIkebe SIkebe merged commit 5e4d041 into master Aug 22, 2020
@SIkebe SIkebe mentioned this pull request Aug 22, 2020
Open
6 tasks
@takezoe takezoe deleted the fix-branch-setting branch August 22, 2020 19:40
@takezoe takezoe changed the title Handle branch contains / properly in branch settings Handle branch which contains / properly in branch settings Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SIkebe SIkebe SIkebe approved these changes

Assignees
No one assigned
Labels
bug
Milestone
4.35.0
Development

Successfully merging this pull request may close these issues.

issue #1479 has not been fixed
2 participants
@takezoe @SIkebe