Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of characters for user completion and issue completioin #2534

Merged
merged 2 commits into from Sep 6, 2020
Merged

Limit the number of characters for user completion and issue completioin #2534

merged 2 commits into from Sep 6, 2020

Conversation

onukura
Copy link
Member

@onukura onukura commented Aug 29, 2020 •
edited

Before submitting a pull-request to GitBucket I have first:

  • read the contribution guidelines
  • rebased my branch over master
  • verified that project is compiling
  • verified that tests are passing
  • squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • marked as closed using commit message all issue ID that this PR should correct

About this PR

This PR fix #2531 .

  • limit the number of characters for issue completion to 50.

  • limit the number of characters for user completion to 25(user name) + 25(full name) = 50.

Screenshot

image

image

@onukura onukura mentioned this pull request Aug 29, 2020
Closed
takezoe
takezoe approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me.

By the way, we have a similar method helpers.cut() which is designed to use in view. However, it's no longer used in GitBucket codebase. Can we remove it in this pull request at the same time?

@takezoe takezoe added this to the 4.35.0 milestone Sep 5, 2020
@onukura
Copy link
Member Author

onukura commented Sep 5, 2020 •
edited

@takezoe

By the way, we have a similar method helpers.cut() which is designed to use in view. However, it's no longer used in GitBucket codebase. Can we remove it in this pull request at the same time?

I removed herplers.cut at d70dd66. I didn't notice there is this method... sorry.

@takezoe takezoe merged commit 0da781c into gitbucket:master Sep 6, 2020
@onukura onukura deleted the fix-issue-completion-style branch September 7, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takezoe takezoe takezoe approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
4.35.0
Development

Successfully merging this pull request may close these issues.

Autocomplete window messed up if candidate is too long
3 participants
@onukura @takezoe @SIkebe