Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow selection of always visible scrollbar #4083

Merged

Conversation

H1ghBre4k3r
Copy link
Contributor

This PR introduces the possibility to always show the scrollbar. As mentioned in #4067, this provides a more accessible interface for interaction via assistive technology, e.g., eye trackers.

Closes #4067

@H1ghBre4k3r H1ghBre4k3r marked this pull request as draft June 14, 2024 14:25
@H1ghBre4k3r H1ghBre4k3r marked this pull request as ready for review June 14, 2024 14:25
@PavelLaptev PavelLaptev self-requested a review June 15, 2024 16:08
@PavelLaptev
Copy link
Contributor

@H1ghBre4k3r thank you for the PR. I've fixed a few bugs:

  1. The scroll was always visible, even if the track and the thumb had the same height.
  2. For the "always visible" setting, the scroll was hidden after a timeout.
Screen.Recording.2024-06-16.at.16.34.55.mov

@H1ghBre4k3r
Copy link
Contributor Author

H1ghBre4k3r commented Jun 16, 2024

@PavelLaptev thanks a lot for fixing the bugs! Apparently, I missed them at first - sorry for that! 😅

I'll have a look into your commit to get a better overview of the code base.

@PavelLaptev
Copy link
Contributor

@H1ghBre4k3r all good, thank you :-)
I'll merge the PR in an hour.

@PavelLaptev PavelLaptev merged commit fdb4fda into gitbutlerapp:master Jun 16, 2024
15 checks passed
@H1ghBre4k3r H1ghBre4k3r deleted the Allow-always-visible-scrollbar branch June 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Feature: Optionally disable scrollbar hiding
2 participants