Skip to content

Commit

Permalink
fallback: change a list of if conditions to a switch statement
Browse files Browse the repository at this point in the history
This used to do a lot more but now it can be handled as simple switch
statement. Bonus: we get to log a bug if we ever get here in NONE state.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
  • Loading branch information
whot committed Aug 3, 2018
1 parent e55c54e commit da0a630
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions src/evdev-fallback.c
Expand Up @@ -825,23 +825,32 @@ fallback_handle_state(struct fallback_dispatch *dispatch,
if (!slot->dirty)
continue;

if (slot->state == SLOT_STATE_BEGIN) {
switch (slot->state) {
case SLOT_STATE_BEGIN:
sent = fallback_flush_mt_down(dispatch,
device,
i,
time);
slot->state = SLOT_STATE_UPDATE;
} else if (slot->state == SLOT_STATE_UPDATE) {
break;
case SLOT_STATE_UPDATE:
sent = fallback_flush_mt_motion(dispatch,
device,
i,
time);
} else if (slot->state == SLOT_STATE_END) {
break;
case SLOT_STATE_END:
sent = fallback_flush_mt_up(dispatch,
device,
i,
time);
slot->state = SLOT_STATE_NONE;
break;
case SLOT_STATE_NONE:
/* touch arbitration may swallow the begin,
* so we may get updates for a touch still
* in NONE state */
break;
}

slot->dirty = false;
Expand Down

0 comments on commit da0a630

Please sign in to comment.