Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Test Suite To Execute Using Live Onchain Proposal Data #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updates Test Suite To Execute Using Live Onchain Proposal Data #27

wants to merge 4 commits into from

Conversation

apbendi
Copy link
Collaborator

@apbendi apbendi commented Aug 9, 2023 •
edited

Note: the linter is currently failing because I added this public method to override the proposer during tests to the Propose script.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 9, 2023
View reviewed changes
script/Propose.s.sol Fixed Show fixed Hide fixed
alexkeating
alexkeating reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left one small comment

test/GitcoinGovernor.t.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apbendi @alexkeating @mds1