Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Optimizations (requested by @xhmikosr) #389

Open
3 of 11 tasks
coderberry opened this issue Mar 9, 2019 · 1 comment
Open
3 of 11 tasks

Optimizations (requested by @xhmikosr) #389

coderberry opened this issue Mar 9, 2019 · 1 comment
Assignees
Labels
enhancement Enhancing an existing feature

Comments

@coderberry
Copy link
Contributor

coderberry commented Mar 9, 2019

Image Optimizations

  • Ensure all images are optimized using ImageOptim
  • Support retina images on image tags
  • Consider adding extension to image uploads
  • Add no-sniff for the images (CDN) because we serve them without extension

Ad Optimizations

  • Specify the image dimensions in the HTML b/c HTML is drawn first and avoid reflows
  • Ensure ad rendering does not proxy through CloudFlare
  • Add cache-control to header of files, even if it's max-age: 0

Documentation Optimizations

  • Document supported browsers
  • Document reason for calling two px.js calls in embed

CSS Optimizations

  • Replace all 0px with 0 to prevent quote escapes
  • Replace obsolete attribute align="center" with CSS text-align

Retina example:

<img class="img-fluid mt-3 mx-auto"
    srcset="/docs/4.3/assets/img/bootstrap-themes.png,
            /docs/4.3/assets/img/bootstrap-themes@2x.png 2x"
    src="/docs/4.3/assets/img/bootstrap-themes.png"
    alt="Bootstrap Themes" width="500" height="200">

The following doesn't work in IE10. Is there a workaround?

var evt = new Event('codefund');
@coderberry coderberry self-assigned this Mar 9, 2019
@coderberry coderberry added bug Something isn't working enhancement Enhancing an existing feature and removed bug Something isn't working labels Mar 9, 2019
@XhmikosR
Copy link
Contributor

XhmikosR commented Mar 10, 2019

I want to add another thing. We need to verify the 3rd parameter in all xhr.open calls is either set to true or absent (which means it's true IIRC). Personally I'd set it explicitly to true.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancing an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants