DG: fetch token/match info only if token available #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKurt
requested review from
boudra,
gravityblast,
thelostone-mc,
codenamejason and
bhargavaparoksham
codenamejason
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks like it's working 🤗
This is the token caught without price data as exptected -> https://sepolia.etherscan.io/address/0x601Da861335533c38Bc2CAeb90709c5371762559
thelostone-mc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable using custom tokes on direct grants, this PR makes the amount in usd and match token info optional. Since direct grants does not have a matching pool and a match token and we do not display the USD value on the frontend, we default them to 0.
That allows us to insert the application payout without this information, else the payout would be dropped.