-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam, app): adds Bright Id Stamp #126
Conversation
a4f8655
to
eb42011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking, but it seems like the new ed25519-related dependencies in app/package.json
aren't used anymore?
eb42011
to
9bc9153
Compare
This is a quick change. I just pushed changes to resolve this |
export const SUCCESFUL_BRIGHTID_RESULT: VerifiableCredentialRecord = { | ||
record: { | ||
type: "Brightid", | ||
address: "0xcF323CE817E25b4F784bC1e14c9A99A525fDC50f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a real address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my comments are mostly on test files with the exception of the selfID.id
comments -
I have some changes going in shortly which should ensure that the userDid
is the users did:pkh
- so I think we can go ahead and merge this and fix everything up in my PR.
- adds BrightId verification steps on iam server failure - adds toast messages - adds procedures to verify and sponsor a user with BrightId Closes #1
9bc9153
to
059e40a
Compare
Closes #1