feat(iam, app): adds Bright Id Stamp #126

farque65 · 2022-05-31T21:27:00Z

adds BrightId verification steps on iam server failure
adds toast messages
adds procedures to verify and sponsor a user with BrightId
Added BRIGHTID_PRIVATE_KEY to Review, Staging and Production AWS Secret Managers

Closes #1

app/components/ProviderCards/BrightidCard.tsx

app/config/providers.ts

app/context/userContext.tsx

iam/package.json

iam/src/procedures/brightid.ts

types/src/brightid.d.ts

yarn.lock

shavinac

not blocking, but it seems like the new ed25519-related dependencies in app/package.json aren't used anymore?

farque65 · 2022-06-01T14:08:05Z

ed25519

This is a quick change. I just pushed changes to resolve this

gdixon · 2022-06-01T14:13:29Z

app/__test-fixtures__/verifiableCredentialResults.ts

+export const SUCCESFUL_BRIGHTID_RESULT: VerifiableCredentialRecord = {
+  record: {
+    type: "Brightid",
+    address: "0xcF323CE817E25b4F784bC1e14c9A99A525fDC50f",


Is this a real address?

gdixon

I think my comments are mostly on test files with the exception of the selfID.id comments -

I have some changes going in shortly which should ensure that the userDid is the users did:pkh - so I think we can go ahead and merge this and fix everything up in my PR.

app/__test-fixtures__/verifiableCredentialResults.ts

app/context/userContext.tsx

iam/__tests__/brightid.test.ts

- adds BrightId verification steps on iam server failure - adds toast messages - adds procedures to verify and sponsor a user with BrightId Closes #1

farque65 assigned farque65 and shavinac May 31, 2022

farque65 requested review from dhxdev, shavinac and gdixon May 31, 2022 21:27

shavinac reviewed May 31, 2022

View reviewed changes

farque65 force-pushed the brightid-stamp-wip branch from a4f8655 to eb42011 Compare June 1, 2022 04:16

farque65 requested a review from shavinac June 1, 2022 13:49

shavinac approved these changes Jun 1, 2022

View reviewed changes

farque65 force-pushed the brightid-stamp-wip branch from eb42011 to 9bc9153 Compare June 1, 2022 14:06

gdixon reviewed Jun 1, 2022

View reviewed changes

gdixon approved these changes Jun 1, 2022

View reviewed changes

app/__test-fixtures__/verifiableCredentialResults.ts Outdated Show resolved Hide resolved

app/context/userContext.tsx Outdated Show resolved Hide resolved

iam/__tests__/brightid.test.ts Outdated Show resolved Hide resolved

feat(iam, app): adds Bright Id Stamp

059e40a

- adds BrightId verification steps on iam server failure - adds toast messages - adds procedures to verify and sponsor a user with BrightId Closes #1

farque65 force-pushed the brightid-stamp-wip branch from 9bc9153 to 059e40a Compare June 1, 2022 14:47

gdixon merged commit e725609 into main Jun 1, 2022

farque65 deleted the brightid-stamp-wip branch June 1, 2022 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iam, app): adds Bright Id Stamp #126

feat(iam, app): adds Bright Id Stamp #126

farque65 commented May 31, 2022 •

edited

Loading

shavinac left a comment

farque65 commented Jun 1, 2022 •

edited

Loading

gdixon Jun 1, 2022

farque65 Jun 1, 2022 •

edited

Loading

gdixon left a comment •

edited

Loading

feat(iam, app): adds Bright Id Stamp #126

feat(iam, app): adds Bright Id Stamp #126

Conversation

farque65 commented May 31, 2022 • edited Loading

shavinac left a comment

Choose a reason for hiding this comment

farque65 commented Jun 1, 2022 • edited Loading

gdixon Jun 1, 2022

Choose a reason for hiding this comment

farque65 Jun 1, 2022 • edited Loading

Choose a reason for hiding this comment

gdixon left a comment • edited Loading

Choose a reason for hiding this comment

farque65 commented May 31, 2022 •

edited

Loading

farque65 commented Jun 1, 2022 •

edited

Loading

farque65 Jun 1, 2022 •

edited

Loading

gdixon left a comment •

edited

Loading