fix: need to click next twice and verification error #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianHymer
reviewed
Jul 3, 2024
lucianHymer
reviewed
Jul 3, 2024
nutrina
requested changes
Jul 5, 2024
nutrina
force-pushed
the
2663-indicate-error
branch
from
aca05a6
to
6aab25c
Compare
nutrina
previously requested changes
Jul 5, 2024
tim-schultz
dismissed
nutrina’s stale review
Error was happening within GenericPlatform and has been resolved. Not in InitiateReverifyStampsButton
tim-schultz
force-pushed
the
2663-indicate-error
branch
from
d30c2a6
to
9a11e4e
Compare
lucianHymer
reviewed
Jul 9, 2024
| await claimCredentials(async () => await Promise.resolve(), [stamp]); | ||
| await claimCredentials( | ||
| async () => await Promise.resolve(), | ||
| () => {}, |
There was a problem hiding this comment.
Do we not need to provide an error handler here? Fine if not, just wanted to call this out in case it was an oversight!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2663