Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kudos QA & feedback 2018/09/24 #2627

Closed
octavioamu opened this issue Oct 31, 2018 · 3 comments
Closed

kudos QA & feedback 2018/09/24 #2627

octavioamu opened this issue Oct 31, 2018 · 3 comments
Labels
Gitcoin Kudos Gitcoin Kudos

Comments

@octavioamu
Copy link
Contributor

From @owocki on September 24, 2018 16:53

general

  1. all kudos pages should be added to StaticViewSitemap in sitemaps.py so that search engines know about them - AnonymousUser #117
  2. I can't login, i get a requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github.com/user?access_token=37ce359b9f1e7bb0500cc9647b6dc985cd2bd9e5 -Some of the buttons are glitchy and unpolished.  #126

Marketplace

  1. Kudos search still needs this fix -- /slack page content view does not fill page width on mobile #105
  2. Sort by price still doesnt work -Simplify bounty management command #93

Kudos Detail Page

  1. kudos.views.detail should have the humanized name as the title, not the unhumanized name example - Specify validation error for email validation checks #118
  2. tags should be clickable - Transaction Underpriced Issue #114
  3. if a kudos has no clones left , the 'send kudos' button should be greyed out and there should be a tooltip explaining why its greyed out - doc: added contributing.md #97
  4. the kudos url should be http://209.97.155.182/kudos/92/vitalik-genesis not http://209.97.155.182/kudos/92 for SEO purposes - Python comment linting and semicolon/unused import removal #119
  5. all of the kudos details should be added to sitemaps.py so that search engines know about them - AnonymousUser #117

Emails

  1. All Kudos emails need to be previewable in the browser here => https://github.com/gitcoinco/web/blob/master/app/app/urls.py#L256-L314 - Error in sync_profile #120
  2. did we ever get the SVG to render in an email client? Whats the latest on that? - Database files not compatible with Postgres 10.x #78

Mint Kudos

  1. This page http://209.97.155.182/kudos/mint is completely broken. Its probably worth removing (or putting behind a feature flag) and just linking this button to https://github.com/gitcoinco/kudos/badges/issues/new - expire email should be targeted to personas #96

Send Kudos

  1. the down key does not work on the autocomplete -- please enable the arrows to be able to move through github usernames - Add missing migrations #121
  2. if a gen0 kudos has no clones left, then this page should error out and tell the user to select a new kudos from the marketplace - General python cleanup #122
  3. i still can't send a kudos while not logged in (here is the error im seeing), so i can't QA the rest of the flow.. To Be Continued.... - Pytest version conflict with ethereum package #123
  4. kudos images are the wrong URL and arent showing up screenshot looks like they are missing a slash: http://kudosdemo.gitcoin.codynamic/avatar/octavioamu - Resolve false fail on Travis #124

Copied from original issue: gitcoinco/gitcoin-erc721#115

@octavioamu
Copy link
Contributor Author

From @owocki on September 24, 2018 16:54

continuation of gitcoinco/gitcoin-erc721#66

@octavioamu
Copy link
Contributor Author

From @jasonrhaas on September 25, 2018 0:13

@owocki I linked each item to its corresponding Github ticket. Me and @octavioamu will attempt to prioritize the tickets, and put them in order in the Backlog and To Do columns. I'm going to try to use the "To Do" as the tickets "for this week", and order the Backlog in order of importance (highest priority is at the top). Feel free to re-adjust the prioritization as necessary.

@octavioamu
Copy link
Contributor Author

From @jasonrhaas on October 2, 2018 16:24

Most of these are either already merged in, or fixed, pending PR review and merge 🎊 . More details can be found in the individual tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

No branches or pull requests

2 participants