Merge pull request #11 from gitcommitshow/chore-test

fix: failing archive test due to data type mismatch
gitcommitshow · Dec 11, 2023 · c6d25c6 · c6d25c6
2 parents 713ef19 + 363d1f1
commit c6d25c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -9,9 +9,9 @@ const OCK = {
     contributors: {
         github: {
             archive: async function(owner, options){
-                contributorsLib.archiveContributorsLeaderboard(owner, options)
-            }
-        }
+                return contributorsLib.archiveContributorsLeaderboard(owner, options)
+            },
+        },
     }
 }
 

diff --git a/test/index.test.js b/test/index.test.js
@@ -12,11 +12,10 @@ describe('index.js', function() {
     describe('#OCK.contributors.github.archive(REPO_OWNER, options);', async function() {
         it('should start the task of archiving contributors for REPO_OWNER', async function() {
           this.timeout(100000);
-          let contributorsHandlesString = await OCK.contributors.github.archive(contributorsFixture.VALID_REPO_OWNER);
-          assert.isNotNull(contributorsHandlesString);
-          expect(contributorsHandlesString).to.be.not.empty;
-          expect(contributorsHandlesString).to.include('@');
-          // expect(str).to.include(',');
+          let contributorsHandlesArray = await OCK.contributors.github.archive(contributorsFixture.VALID_REPO_OWNER);
+          assert.isNotNull(contributorsHandlesArray, "No contributors github handles returned");
+          expect(contributorsHandlesArray).to.be.an('array');
+          expect(contributorsHandlesArray).to.have.lengthOf.at.least(contributorsFixture.ALL_REPO_CONTRIBUTOR_COUNT);
         })
     })