Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better comment in case of backport failure #81

Closed
oliverpool opened this issue May 11, 2023 · 6 comments · Fixed by #82
Closed

Better comment in case of backport failure #81

oliverpool opened this issue May 11, 2023 · 6 comments · Fixed by #82

Comments

@oliverpool
Copy link

Suggested in go-gitea/gitea#24470 (comment)

Instead of the current message

`I was unable to create a backport for ${giteaVersion.majorMinorVersion}. @${originalPr.user.login}, please send one manually. :tea:`,

The bot could point to the contrib/backport tool (untested):

`I was unable to create a backport for ${giteaVersion.majorMinorVersion}. @${originalPr.user.login}, please send one manually. :tea:

\`\`\`
go run ./contrib/backport ${originalPr.number}
...  // fix git conflicts if any
go run ./contrib/backport --continue
\`\`\`
`
@yardenshoham
Copy link
Collaborator

@zeripath would this suggestion be correct?

@silverwind
Copy link
Collaborator

I haven't personally used that script, so I can't speak for it, but I guess I will try next time.

@zeripath
Copy link

I think it might be helpful to add the --version option to the first command but that is the intended use of the --continue option

@oliverpool
Copy link
Author

Note: by untested, I meant that I didn't test the typescript code. Regarding the 2 bash commands, I actually used them for the mentioned PR (with the --no-push flag, since I prefer manually pushing)

@zeripath
Copy link

Glad it works for you @oliverpool nice to know that I've done it right

@yardenshoham
Copy link
Collaborator

PRs for this would be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants