fix: release page for empty or non-existing target #24470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
approved these changes
May 9, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 10, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @oliverpool, please send one manually. 🍵 |
GiteaBot
added
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 10, 2023
* upstream/main: Remove unnecessary code (go-gitea#24610) Fix commits pushed with deploy keys not shown in dashboard (go-gitea#24521) fix: release page for empty or non-existing target (go-gitea#24470) Filter get single commit (go-gitea#24613) Attach a tooltip to the action status icon (go-gitea#24614) Use official Vue extension in Gitpod (go-gitea#24609) Create a branch directly from commit on the create branch API (go-gitea#22956) Make repository response support HTTP range request (go-gitea#24592)
oliverpool
added a commit
to oliverpool/gitea
that referenced
this pull request
May 11, 2023
Backport go-gitea#24470 Fixes go-gitea#24145 --- To solve the bug, I added a "computed" `TargetBehind` field to the `Release` model, which indicates the target branch of a release. This is particularly useful if the target branch was deleted in the meantime (or is empty). I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead of checking that a branch exists and then call `GetBranchCommit`, I immediately call `GetBranchCommit` and handle the `git.ErrNotExist` error. This optimization is covered by the added unit test.
|
Backport created: #24659 It would be even nicer if the
|
Raise issue here: https://github.com/GiteaBot/gitea-backporter/issues |
|
@silverwind thanks for the hint, I opened an issue (I had no idea where the bot code was located :) |
silverwind
pushed a commit
that referenced
this pull request
May 12, 2023
Backport #24470 Fixes #24145 --- To solve the bug, I added a "computed" `TargetBehind` field to the `Release` model, which indicates the target branch of a release. This is particularly useful if the target branch was deleted in the meantime (or is empty). I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead of checking that a branch exists and then call `GetBranchCommit`, I immediately call `GetBranchCommit` and handle the `git.ErrNotExist` error. This optimization is covered by the added unit test. _contributed in the context of @forgejo_
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jun 3, 2023
Backport go-gitea#24470 Fixes go-gitea#24145 --- To solve the bug, I added a "computed" `TargetBehind` field to the `Release` model, which indicates the target branch of a release. This is particularly useful if the target branch was deleted in the meantime (or is empty). I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead of checking that a branch exists and then call `GetBranchCommit`, I immediately call `GetBranchCommit` and handle the `git.ErrNotExist` error. This optimization is covered by the added unit test. _contributed in the context of @forgejo_ (cherry picked from commit cb7ba89)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24145
To solve the bug, I added a "computed"
TargetBehindfield to theReleasemodel, which indicates the target branch of a release.This is particularly useful if the target branch was deleted in the meantime (or is empty).
I also did a micro-optimization in
calReleaseNumCommitsBehind. Instead of checking that a branch exists and then callGetBranchCommit, I immediately callGetBranchCommitand handle thegit.ErrNotExisterror.This optimization is covered by the added unit test.
contributed in the context of @forgejo