Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC behavior in the last version #162

Closed
blacklord049 opened this issue Mar 1, 2016 · 16 comments
Closed

TOC behavior in the last version #162

blacklord049 opened this issue Mar 1, 2016 · 16 comments
Milestone

Comments

@blacklord049
Copy link

Hello,

I made a screenshot to easily describe the "problem".
http://image.noelshack.com/fichiers/2016/09/1456819927-toc.jpg

It would be nice to have the toc fixed on the right like when it's collapsed. I don't know if it's possible.
Thank you !

@asmith3006
Copy link
Contributor

I would love an option in the admin interface to prevent the menu from collapsing if this is possible?

@blacklord049
Copy link
Author

Plus an option to have the toc always collapsed when landing on another page.

@giterlizzi
Copy link
Owner

Hi! I'm to work to create a new options to add a better control on TOC:

  • tocAffix : Enable TOC Affixing
  • tocCollapse: Multiple checkbox options
    • subSections: Replace the tocCollapseSubSections option
    • onLoad: Automatic Collapse (aka close) the TOC
    • onAffix: Collapse (aka close) the TOC during in affix event (the normal behavior)

With this option it's possible replicate the original DokuWiki behavior:

  • tocAffix: off
  • tocCollapse.onLoad : off

Joseph

@blacklord049
Copy link
Author

(As you can see on my screenshot the jumbotron is not reduced when the TOC is over, but the text is shifted to the left)

@blacklord049
Copy link
Author

Will there be some kind of fix ? :-)

@blacklord049
Copy link
Author

blacklord049 commented May 17, 2016

Another screenshot to describe the problem (eg: with a callout) :

another

Would be nice to have the toc always on the right :

1458657943-whatweshouldhave

@tysoncecka
Copy link
Contributor

I get this too on the Lumen theme where when the affix-top class is applied the TOC doesn't "float" over the rest of the page like it does when it is affixed...

@blacklord049
Copy link
Author

Any news for this enhancement ?

@tysoncecka
Copy link
Contributor

As I temporary fix I added this to my userall.css

body.lumen #dokuwiki__toc_wrapper.affix-top { position: fixed; }

Which just makes the TOC always be affixed to the upper right. The positioning for me isn't the best but it doesn't mess up the page elements now.

@blacklord049
Copy link
Author

Strange because it doesn't change anything. I used the Advanced config to add the style and purge CSS cache but the TOC is not on the upper right like it should.

@blacklord049
Copy link
Author

blacklord049 commented Jun 10, 2016

Sorry. It's working now, I just changed lumen with the bootstrap theme I use

giterlizzi added a commit that referenced this issue Jun 11, 2016
What's new in this TOC:

  * Now the TOC is in different column to not interfere with page flow and Bootstrap Wrapper components (eg. jumbotron, alerts, callouts, etc)
  * Automatic height resize of TOC
  * Initial support to mobile layout (full support in progress)
  * Manual TOC show/hide
  * Automatic TOC hide during scroll
  * Automatic TOC show when scoll up
  * New option to select a position of TOC (default: right)


(#162,#142,#103,#78,#68)
@giterlizzi
Copy link
Owner

Hi! Sorry for my delay!
In this period i have a created and fixed some issue for TOC. To test and see this TOC, checkout feature/toc branch.

@tysoncecka
Copy link
Contributor

Thanks! I tried out the branch version and on my theme (lumen, not fluid) I'm still getting the body text moving around when the TOC collapses. It's different now since the TOC seems to adjust the column width rather than just wrap the text around it but it still isn't desirable for me. I would like the option to have the TOC be entirely in the empty space to the right of my body content so that it doesn't adjust the size/positioning of any page contents.

giterlizzi added a commit that referenced this issue Jun 16, 2016
…disable automatic collapse of the TOC during the scroll of the page (thanks to @tysoncecka on #162).

(#162,#142,#103,#78,#68)
@giterlizzi giterlizzi modified the milestone: v2016-06 Jun 23, 2016
@tysoncecka
Copy link
Contributor

Hello, is it possible to get an option for starting with the TOC collapsed? I think that would solve a lot of my issues with the TOC right now.

Thanks

@polyzen
Copy link
Contributor

polyzen commented Jul 13, 2016

@tysoncecka, if that is a separate request, please open another issue. It's tricky keeping track of all these different TOC issues. :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants