Add support of getting authenticated user assigned issues #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
May 7, 2024
Git.hub/Client.cs
Outdated
| /// <param name="state">state of the issues returned. Choice: "open", "closed", "all"</param> | ||
| /// <param name="includePullRequests">true to include pull requests; otherwise, false.</param> | ||
| /// <returns>a list of issues assigned to the authenticated user.</returns> | ||
| public List<Issue> GetAssignedIssues(string state = "open", bool includePullRequests = false) |
There was a problem hiding this comment.
I'd caution against returning mutable collections. Consider returning a read-only list.
There was a problem hiding this comment.
I have added a refactoring commit to stay consistent and do the same for all the lists returned.
RussKie
approved these changes
May 7, 2024
gerhardol
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be able to have GitHub issues support in commit templates: