Upgrade to .NET 5.0 #46
Conversation
lekhmanrus
force-pushed
the
net5
branch
2 times, most recently
from
6847b92
to
7d7c497
Compare
| <PropertyGroup> | ||
| <TargetFramework>net461</TargetFramework> | ||
| <UseWindowsForms>true</UseWindowsForms> | ||
| <TargetFramework>net5.0-windows7.0</TargetFramework> |
There was a problem hiding this comment.
| <TargetFramework>net5.0-windows7.0</TargetFramework> | |
| <TargetFramework>net5.0-windows</TargetFramework> |
There was a problem hiding this comment.
Getting an error:
Error NU1012 Some included files are included under TFMs which are missing a platform version: net5.0-windows
GitExtensions.GerritPlugin C:\Program Files\dotnet\sdk\5.0.402\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets 221
src/GitExtensions.GerritPlugin/GitExtensions.GerritPlugin.nuspec
Outdated
Show resolved
Hide resolved
| <dependency id="GitExtensions.Extensibility" version="[0.1.0, 1.0.0)" /> | ||
| </group> | ||
| <!-- To fix Warning NU5128 Add a dependency group for net5.0-windows7.0 to the nuspec --> | ||
| <group targetFramework="net5.0-windows7.0"> |
There was a problem hiding this comment.
Can this be just net5.0-windows?
There was a problem hiding this comment.
I was not able to resolve an error that VS throws after changing to net5.0-windows:
Error NU1012 Some dependency group TFMs are missing a platform version: net5.0-windows
GitExtensions.GerritPlugin C:\Program Files\dotnet\sdk\5.0.402\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets 221
|
IIUIC @maraf is still working on a port to .NET for the Plugin Manager, gitextensions/gitextensions.pluginmanager#57. |
|
I'm sorry for the delay. As I'm starting a new job on Monday, last few weeks were a bit hectic. I try to finish the PM this weekend. |
|
Hi, is there a way to tie GitExtensions plugin to the specific GE version? E.g. Gerrit plugin with .net5 support to GE >=3.5. |
|
Yes, see gitextensions/gitextensions.pluginmanager#64. |
lekhmanrus
force-pushed
the
net5
branch
2 times, most recently
from
f2a7ede
to
2ef2705
Compare
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="JetBrains.Annotations" Version="2021.2.0"> | ||
| <PackageReference Include="JetBrains.Annotations" Version="2021.3.0"> |
There was a problem hiding this comment.
You may want to consider use Roslyn annotations instead of those provided by JetBrains.
| </group> | ||
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="..\..\LICENSE.md" target="\" /> | ||
| <file src="bin\$configuration$\net461\GitExtensions.GerritPlugin.dll" target="\lib\net461\" /> | ||
| <file src="bin\$configuration$\net5.0-windows7.0\GitExtensions.GerritPlugin.dll" target="\lib\net5.0-windows7.0\" /> |
There was a problem hiding this comment.
I don't think Plugin Manager will look at this TFM. Have you tested installing the nuget?
There was a problem hiding this comment.
Hi @maraf,
Just tested - you are right. I'm able to install Gerrit plugin v2, but looks like it is not installed even if I see it's installed at Plugin manager. How can I fix that? If I switch TFM to just net5.0-windows without version I have an error:
Error NU1012 Some dependency group TFMs are missing a platform version: net5.0-windows
GitExtensions.GerritPlugin C:\Program Files\dotnet\sdk\6.0.101\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets 221
Looks like a target platform version is required (based on this issue)?
There was a problem hiding this comment.
Would this work?
<file src="bin\$configuration$\net5.0-windows7.0\GitExtensions.GerritPlugin.dll" target="\lib\" />There was a problem hiding this comment.
There was a problem hiding this comment.
How can I fix that? If I switch TFM to just
net5.0-windowswithout version I have an error:
I have never seen that, but according the issue you mentioned and PR inside it, it seems you are doing it correctly.
There was a problem hiding this comment.
Thanks @maraf! I'll do PR to fix that.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
.net framework v4.6.1
Issue Number: #44
What is the new behavior?
.net 5
Does this PR introduce a breaking change?
Requires Git Extensions >=v3.6.