Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target branch selection settings #68

Merged

Conversation

lekhmanrus
Copy link
Collaborator

@lekhmanrus lekhmanrus commented Jan 18, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build related changes
  • Documentation
  • Other:

What is the current behavior?

Branch selection is based on a local branch only.

Issue Number: #53

What is the new behavior?

Adds Target branch selection settings to allow control over which default branch for publish would be selected:

  • selection based on the local branch
  • reading from the .gitreview file

Users can setup/override the default behaviour.

Does this PR introduce a breaking change?

  • Yes
  • No

@lekhmanrus lekhmanrus force-pushed the target-branch-selection-settings branch 2 times, most recently from e0ccc64 to 9fc84b4 Compare January 18, 2023 18:26
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/GitExtensions.GerritPlugin/FormGerritPublish.cs Outdated Show resolved Hide resolved
@lekhmanrus
Copy link
Collaborator Author

Could somebody review this pull request, please?

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem OK to me in a brief review. Not a user for this plugin.
@lekhmanrus Do you want an approval to get going, you will have to handle any issues regardless?

@lekhmanrus
Copy link
Collaborator Author

@gerhardol yes, please

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as requested

@lekhmanrus lekhmanrus merged commit 5c36046 into gitextensions:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants