Make compatibility with GitExtensions v4.1 & Gerrit server v3.7.0 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception - Due to the move of GitCommands Fix the parsing of the remote command lines output to retrieve the gerrit change URI - Keep the legacy parsing using 'New Changes' line - Following gerrit v3.7.0 remote outputs modifications take care of '[NEW]' at the end of line - Use a global regex on the command line ouput to retrieve the change URI in bot cases - Add a unit test with both use cases with command outputs test resource files Update the README to indicates supported version (master-branch needs to be updated at release time depending of the new version the plugin will take)
RussKie
reviewed
Sep 18, 2023
Comment on lines
20
to
34
| <None Update="TestResources\NewChange_GerritLegacy.txt"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="TestResources\NewChange_GerritNew.txt"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="TestResources\UnparsableUri.txt"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="TestResources\UpdatedChange_GerritNew.txt"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="TestResources\UpdatedChange_GerritLegacy.txt"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> |
There was a problem hiding this comment.
Suggested change
| <None Update="TestResources\NewChange_GerritLegacy.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> | |
| <None Update="TestResources\NewChange_GerritNew.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> | |
| <None Update="TestResources\UnparsableUri.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> | |
| <None Update="TestResources\UpdatedChange_GerritNew.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> | |
| <None Update="TestResources\UpdatedChange_GerritLegacy.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> | |
| <None Update="TestResources\*.txt"> | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |
| </None> |
| @@ -27,6 +28,26 @@ internal static class GerritUtil | |||
| var fetchUrl = GetFetchUrl(module, remote); | |||
|
|
|||
| return await RunGerritCommandAsync(owner, module, command, fetchUrl, remote, stdIn).ConfigureAwait(false); | |||
| } | |||
|
|
|||
| public static bool HadNewChange(string commandPrompt, out string changeUri) | |||
There was a problem hiding this comment.
Assert that commandPrompt isn't null or empty.
|
With pleasure, |
3 tasks
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing method implementation OsShellUtil.OpenUrlInDefaultBrowse exception:
Fix the parsing of the remote command lines output to retrieve the gerrit change URI:
Update the README to indicate supported version (master-branch needs to be updated at release time depending of the new version the plugin will take)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current behaviour is an exception with GitExtensions v4.1 when opening the change URI after publishing it
It's also to have the new change URI poping up with the GerritServer v3.7.0
Issue Number: N/A
What is the new behavior?
The plugin correctly open new changes URIs in GitExtensions v4.1 and with GerritServer v3.7.0
Does this PR introduce a breaking change?
Other information
Like last time : I used this plugin every day and could be cool if we can have a quick release of it to have the benefits of the v4.1 of GitExtensions 😇