Skip to content

Commit

Permalink
Use GitExtensions.Extensibility 1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
RussKie committed Dec 7, 2023
1 parent 0b54bcb commit a2aff39
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 30 deletions.
11 changes: 11 additions & 0 deletions NuGet.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<clear />
<add key="local" value="D:\Development\gitextensions\Externals\GitExtensions.Extensibility\artifacts\Release\publish\" />
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
</packageSources>
<disabledPackageSources>
<clear />
</disabledPackageSources>
</configuration>
2 changes: 1 addition & 1 deletion Packages.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<ItemGroup>
<PackageReference Update="GitExtensions.Extensibility" Version="0.3.*" />
<PackageReference Update="GitExtensions.Extensibility" Version="1.0.*" />
<PackageReference Update="Neptuo" Version="6.0.2" />
<PackageReference Update="Neptuo.Exceptions" Version="1.2.2" />
<PackageReference Update="Neptuo.Observables" Version="2.1.1" />
Expand Down
8 changes: 1 addition & 7 deletions src/GitExtensions.PluginManager/ArgsFix.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace Neptuo
namespace Neptuo
{
public interface ICloneable<T>
{
Expand Down
12 changes: 0 additions & 12 deletions src/GitExtensions.PluginManager/GitExtensions.PluginManager.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,6 @@
<Compile Include="..\PackageManager.UI\Args.cs" Link="Args.cs" />
</ItemGroup>

<ItemGroup>
<Reference Include="GitUI">
<HintPath>$(GitExtensionsPath)\GitUI.dll</HintPath>
</Reference>
<Reference Include="GitUIPluginInterfaces">
<HintPath>$(GitExtensionsPath)\GitUIPluginInterfaces.dll</HintPath>
</Reference>
<Reference Include="ResourceManager">
<HintPath>$(GitExtensionsPath)\ResourceManager.dll</HintPath>
</Reference>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\PackageManager.UI\PackageManager.UI.csproj" ReferenceOutputAssembly="false" />
</ItemGroup>
Expand Down
11 changes: 7 additions & 4 deletions src/GitExtensions.PluginManager/Plugin.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
using GitExtensions.PluginManager.Properties;
using GitUIPluginInterfaces;
using GitExtensions.Extensibility.Git;
using GitExtensions.Extensibility.Plugins;
using GitExtensions.Extensibility.Settings;
using GitExtensions.PluginManager.Properties;
using PackageManager;
using ResourceManager;
using System;
using System.Collections.Generic;
using System.ComponentModel;
Expand Down Expand Up @@ -46,7 +47,9 @@ public override IEnumerable<ISetting> GetSettings()
public override bool Execute(GitUIEventArgs gitUiCommands)
{
string basePath = AppDomain.CurrentDomain.BaseDirectory;
string pluginsPath = ManagedExtensibility.UserPluginsPath;

// TODO: how to provide this?
string pluginsPath = ""; // ManagedExtensibility.UserPluginsPath;

This comment has been minimized.

Copy link
@RussKie

RussKie Dec 7, 2023

Author Member

@maraf this is the only thing I don't know how to resolve.

This comment has been minimized.

Copy link
@maraf

maraf Dec 7, 2023

Member

I don't see any other way than have some API that exposes it. Would AssemblyInternalsVisibleTo (between Extensibility and PluginManager) be too much of a hack?


Args args = new Args();
args.Path = pluginsPath;
Expand Down
6 changes: 1 addition & 5 deletions src/GitExtensions.PluginManager/PluginSettings.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
using GitUIPluginInterfaces;
using GitUIPluginInterfaces.Settings;
using GitExtensions.Extensibility.Settings;
using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace GitExtensions.PluginManager
{
Expand Down
1 change: 0 additions & 1 deletion src/PackageManager.UI/Args.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace PackageManager
{
Expand Down

0 comments on commit a2aff39

Please sign in to comment.